Cancel delayed transitions when InstructionView is detached #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Apr 25, 2018
There was a problem hiding this comment.
Seems legit 🚀
In any case we should consider splitting up InstructionView into smaller components. Right now, it's too long and therefore hard to read and understand. What about extracting some of the view components into their own custom views and use them here?
yep, I agree #599 |
danesfeder
force-pushed
the
dan-cancel-animation
branch
from
5fd9bc5
to
a67b6c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that the delayed transition manager was causing a memory leak when rotating the device quickly / many times at once.