Fix Feedback FAB margins

[Guardiola31337]

• Fixes Navigation UI: Feedback Button #859

• Fixes Feedback FAB margins (matching Sound FAB ones)

Noting that this only happened in devices with low resolution (e.g. Motorola TC55) so friendly reminder here that we should test on those devices as well.

In any case, the distance between sound and feedback buttons is not optimal for that resolution ☝️ (too long IMO), should we consider adding layout support for lower resolutions?

cc @devotaaabel @danesfeder

[danesfeder]

should we consider adding layout support for lower resolutions

Can we add a layout with lower res qualifier to address this. Dropping the margins to 8dp will result in the buttons being too close on high-res devices like the Pixel 2

[Guardiola31337]

@danesfeder

Can we add a layout with lower res qualifier to address this.

Added dimens.xml "default" and mdpi values support in 7326804

BTW we should revisit all hardcoded "dimens" values and 👀 if we want to support any other configurations (screen densities, sizes, etc.).

[danesfeder]

Can we adjust this to 16dp? On higher res devices, the buttons are too close imo, may be more easy to click the wrong one:

[Guardiola31337]

Nah, that's not necessary 👀 fab_margin_bottom which doesn't affect the distance between sound and feedback buttons (it's the same exact value as it was).

[Guardiola31337]

Added dimens.xml "default" and mdpi, hdpi, xhdpi, xxhdpi and xxxhdpi values support in 5134763

BTW we should revisit all hardcoded "dimens" values and 👀 if we want to support any other configurations (screen densities, sizes, etc.).

And also adjust hdpi, xhdpi, xxhdpi and xxxhdpi values so look ✨ for each screen density (now all of them define the same values as the "default" ones).

@danesfeder could you confirm that #878 (comment) is working as expected now?

[danesfeder]

Confirmed, this is working correctly now. Thanks @Guardiola31337

[Danny-James]

@danesfeder should this now be available in the 13.0-SNAPSHOT ?

[danesfeder]

@Danny-James yes 👍

[Danny-James]

@danesfeder Great Stuff, I've tested this and it's working.

[Guardiola31337]

@Danny-James Great to hear, thanks for the update.