Fixed unit type bug #769
Fixed unit type bug #769
Conversation
| @@ -814,15 +814,15 @@ private void updateLandscapeConstraintsTo(int layoutRes) { | |||
| * @param model to provide the current steps and unit type | |||
| */ | |||
| private void updateInstructionList(InstructionModel model) { | |||
| instructionListAdapter.updateSteps(model.getProgress()); | |||
| instructionListAdapter.updateSteps(getContext(), model.getProgress(), locale, unitType); | |||
There was a problem hiding this comment.
Was the locale and unitType moved here so they can be updated on the fly and the list will reflect the latest changes?
There was a problem hiding this comment.
@danesfeder yes because otherwise, the locale was being set in the adapter when it was initialized, which was before the locale was actually set in InstructionView
| public void updateSteps(RouteProgress routeProgress) { | ||
| public void updateSteps(Context context, RouteProgress routeProgress, | ||
| Locale locale, @NavigationUnitType.UnitType int unitType) { | ||
| if (distanceUtils == null) { |
There was a problem hiding this comment.
Would it make sense to store locale or unitType and then check if they have changed / re-initialize DistanceUtils here if they have? I believe the formatting elsewhere (like in InstructionView) can change on the fly.
There was a problem hiding this comment.
@danesfeder I agree, we should probably add something like that to InstructionStepResource too so we're not creating a new DistanceUtils object everytime
No description provided.