Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop scroll of InstructionList before hiding #766

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Conversation

danesfeder
Copy link
Contributor

@danesfeder danesfeder commented Mar 15, 2018

Closes #761

An IllegalStateException was intermittently being thrown when the instruction list was scrolling quickly and then being hidden directly after with TransitionManager.

Stopping the scrolling before hiding the list fixes this:
ezgif com-video-to-gif

@danesfeder danesfeder added bug Defect to be fixed. navigation-ui labels Mar 15, 2018
@danesfeder danesfeder self-assigned this Mar 15, 2018
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 🚀

@danesfeder danesfeder merged commit 8d58d51 into master Mar 16, 2018
@danesfeder danesfeder deleted the dan-rv-list-crash branch March 16, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapbox crashes when tapping banner while still scrolling
2 participants