Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grsmto waypoints support #76

Closed
wants to merge 10 commits into from
Closed

Grsmto waypoints support #76

wants to merge 10 commits into from

Conversation

cammace
Copy link

@cammace cammace commented Jun 7, 2017

Pulled #66 into a branch so CI could run on it. Will continue work on this branch.

cc: @Grsmto

Adrien Grsmto added 10 commits May 29, 2017 19:20
* master:
  fixed review issues
  fixed checkstyle
  fixed endnavigation issue
  removed unused test
  fixed checkstyle
  handle cases when step distance equals zero
  changed navigationActivity name and added a few routeStep test
  Ran tx pull -a  to pull in catalan,french,vietnamese,and swedish
  Added correct config file
@cammace cammace added enhancement ⚠️ DO NOT MERGE PR should not be merged! labels Jun 7, 2017
@cammace cammace added this to the v0.4.0 milestone Jun 7, 2017
@cammace cammace mentioned this pull request Jun 7, 2017
@cammace
Copy link
Author

cammace commented Jun 30, 2017

Hey @Grsmto, is there anything in this PR that is still needed? #111 seems to implement this.

@Grsmto
Copy link

Grsmto commented Jun 30, 2017

Hey @cammace , actually yes, the API of the getRoute() function currently only accepts an origin and destination versus to support waypoints it needs to accept an array of positions (that's what had been done in e3f2290).
Apart from that, #111 should take care of the rest.

Edit: this PR is quite outdated now as it doesn't support the new milestone feature. I kept my fork updated (and merged with the milestone feature). I'm happy to provide another PR again if you actually think about working in this. You can see it there otherwise https://github.com/Grsmto/mapbox-navigation-android/tree/waypoints-support

@cammace
Copy link
Author

cammace commented Jun 30, 2017

I added support for passing in a list of coordinates getRoute() in #111, going ahead and closing this PR.

@cammace cammace closed this Jun 30, 2017
@cammace cammace mentioned this pull request Aug 1, 2017
10 tasks
@cammace cammace deleted the Grsmto-waypoints-support branch August 15, 2017 14:17
LukasPaczos pushed a commit that referenced this pull request Jan 27, 2021
* dokka: remove plugin from undocumented modules

* MapboxRouteOptionsUpdater: fix Bearings combining

* add changelog for 1.4.0-rc.1

* bump mapbox-navigation-native version to 29.0.0 and fix breaking changes

* fix electronic horizon options conflict and update libnavui-base, libnavui-maps and libnavui-util dokka setup

Co-authored-by: Yury Kanetski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ DO NOT MERGE PR should not be merged!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants