Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE with MapRoute click listener #721

Merged
merged 3 commits into from
Feb 26, 2018
Merged

Fix NPE with MapRoute click listener #721

merged 3 commits into from
Feb 26, 2018

Conversation

danesfeder
Copy link
Contributor

Fixes regression from #703

We weren't properly clearing all lists when adding a new set of routes, so crashes would occur after routes were drawn for the second time.

@danesfeder danesfeder added bug Defect to be fixed. navigation-ui labels Feb 26, 2018
@danesfeder danesfeder self-assigned this Feb 26, 2018
Guardiola31337
Guardiola31337 approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although NavigationMapRoute still needs some rework/refactor (there are some pretty long methods, a bunch magic numbers, among other things), let's revisit in a different PR.

@danesfeder danesfeder merged commit 0082458 into master Feb 26, 2018
@danesfeder danesfeder deleted the dan-route-click-npe branch February 26, 2018 18:57
@danesfeder danesfeder mentioned this pull request Feb 26, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

@devotaaabel devotaaabel Awaiting requested review from devotaaabel

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @Guardiola31337