package delivery/ride sharing waypoint demo #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 5, 2018 14:10
…ty. Added alert dialog which is triggered when arriving at a destination.
…o it's item in the menu
…ons. It was instead always using the first set of options that were set.
…ypoint navigation and dialog working, and cleaned up code.
|
Nice work! Looping in @bsudekum and @ericdeveloper in on this as well for 👀. |
Once the next leg has started, I think we should remove the previous destination marker. |
danesfeder
reviewed
Jan 10, 2018
| @@ -341,6 +346,11 @@ public void updateLocationLayer(Location location) { | |||
| * @param options with containing route / coordinate data | |||
| */ | |||
| public void startNavigation(NavigationViewOptions options) { | |||
| for (Marker marker : markers) { | |||
There was a problem hiding this comment.
For clarity, can we extract the removal of these markers into a private method (something like clearMarkers()?
devotaaabel
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
danesfeder
reviewed
Jan 10, 2018
| @@ -84,6 +84,8 @@ public void updateShouldSimulateRoute(boolean shouldSimulateRoute) { | |||
| * @param route to be mocked | |||
| */ | |||
| public void updateRoute(DirectionsRoute route) { | |||
| // MockLocationEngine is deactivated first to avoid weird behavior with subsequent navigation sessions | |||
| deactivateLocationEngine(); | |||
There was a problem hiding this comment.
Can we test with this removed now that we merged in the fix from #646?
danesfeder
approved these changes
Jan 10, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the example for a Package Delivery/Ride Share service that needs to be able to navigate to multiple destinations. On arrival, the driver is given an alert dialog which gives them the option to navigate to next destination, or to cancel.
A few things I wanted to bring up for discussion:
cc. @ericrwolfe @danesfeder