Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification check for valid BannerInstructions before updating #637

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Notification check for valid BannerInstructions before updating #637

merged 1 commit into from
Jan 8, 2018

Conversation

danesfeder
Copy link
Contributor

  • Prevents IndexOutOfBounds with empty BannerInstructions list is found

@danesfeder danesfeder added the bug Defect to be fixed. label Jan 8, 2018
@danesfeder danesfeder self-assigned this Jan 8, 2018
@danesfeder danesfeder merged commit bda98c8 into master Jan 8, 2018
@danesfeder danesfeder deleted the dan-notification-index branch January 8, 2018 21:59
@danesfeder danesfeder mentioned this pull request Jan 9, 2018
Closed
@danesfeder danesfeder mentioned this pull request Jan 23, 2018
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devotaaabel devotaaabel devotaaabel approved these changes

@cammace cammace Awaiting requested review from cammace

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @devotaaabel