Expose listeners in the NavigationView #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vigation-android into devota-expose-listeners
- Started marking TODOs for dispatcher firing points
…vigation-android into devota-expose-listeners
…vigation-android into devota-expose-listeners
|
Noting that this PR will expose the ability to add |
|
Lookin great and verified all listeners are firing correctly- fired reroute listeners using fake GPS updates provided by |
ericrwolfe
reviewed
Dec 19, 2017
| * | ||
| * @since 0.8.0 | ||
| */ | ||
| void onFailedReroute(); |
There was a problem hiding this comment.
Do we want to return the error here?
danesfeder
approved these changes
Dec 20, 2017
There was a problem hiding this comment.
Updated the failed reroute listener to provide an error message now. @devotaaabel great PR - feel free to merge once CI passes ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigationListenerandRouteListenerwere created with methods for listening for navigation/routing events and for influencing reroutes.NavigationViewListenerwas replaced byOnNavigationReadyCallback, andonNavigationFinishedwas moved toNavigationListener. Eventually, the plan is to break up these two listeners into individual listeners for each method, so that people don't have to implement more methods than necessary (i.e. see emptyonNavigationRunningmethod inNavigationActivity).TODO:
NavigationListenervoid onCancelNavigation()void onNavigationFinished()void onNavigationRunning()RouteListenerboolean allowRerouteFrom(Point offRoutePoint)void onOffRoute(Point offRoutePoint)void onRerouteAlong(DirectionsRoute directionsRoute)void onFailedReroute()FeedbackListeneronFeedbackOpened()onFeedbackCancelled()onFeedbackSent(FeedbackItem item)cc @ericrwolfe