Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add software layer type programmatically for Maneuver and Lane View #514

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Add software layer type programmatically for Maneuver and Lane View #514

merged 1 commit into from
Nov 17, 2017

Conversation

danesfeder
Copy link
Contributor

  • Adds software layer type in the View code (required by PaintCode)
  • Removes the layer type set with the XML attributes

As pointed out in #513, this is not immediately obvious for developers to set this in their XML if they want to use either the ManeuverView or TurnLaneView in their own XML layouts

cc @ericrwolfe

@danesfeder danesfeder self-assigned this Nov 17, 2017
@danesfeder danesfeder mentioned this pull request Nov 17, 2017
Closed
@danesfeder danesfeder merged commit 3a8be52 into master Nov 17, 2017
@danesfeder danesfeder deleted the dan-maneuver-view-software branch November 17, 2017 15:33
@danesfeder danesfeder mentioned this pull request Dec 6, 2017
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammace cammace cammace approved these changes

@Guardiola31337 Guardiola31337 Awaiting requested review from Guardiola31337

Assignees

@danesfeder danesfeder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @cammace