Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NavigationView as a lifecycle observer #506

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Add NavigationView as a lifecycle observer #506

merged 2 commits into from
Nov 21, 2017

Conversation

danesfeder
Copy link
Contributor

We already require that the Activity / Fragment inflating NavigationView be a LifecycleOwner:

  • This PR adds the NavigationView as a lifecycle observer allowing us to remove a lot of the required boilerplate code from the Activity

cc @ericrwolfe

@danesfeder danesfeder self-assigned this Nov 15, 2017
@danesfeder danesfeder merged commit a0e4600 into master Nov 21, 2017
@danesfeder danesfeder deleted the dan-nav-view-lifecycle branch November 21, 2017 16:36
@danesfeder danesfeder mentioned this pull request Dec 6, 2017
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

@cammace cammace Awaiting requested review from cammace

Assignees

@danesfeder danesfeder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @Guardiola31337