add nearby coords to RouteProgress #471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 8, 2017 11:20
cammace
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
|
This PRs ready for a review @danesfeder whenever you get a chance. |
|
@danesfeder do we want to wait to merge this in 8.0 or can we move forward with this? |
|
@cammace Yeah let's hold for the |
|
Going to try reviewing this PR this week and seeing what is still applicable and resolve the merge conflicts in a hope to get this either merged or closed. One thing I remember fixing in this PR was issue #304 |
|
@cammace I think decoding the current / upcoming step points and passing them in the route progress adds a lot of value / makes it easier to calculate off route / snap to route. I'm going to work on cleaning this up cc @Guardiola31337 @devotaaabel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.