Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes duplicate check and adds test for new route #443

Merged
merged 3 commits into from
Oct 30, 2017

Conversation

cammace
Copy link

@cammace cammace commented Oct 30, 2017

No description provided.

@cammace cammace added this to the v0.7.0 milestone Oct 30, 2017
@cammace cammace self-assigned this Oct 30, 2017
@cammace cammace requested a review from danesfeder October 30, 2017 19:19
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cammace fixed up checkstyle and tested locally - looks to be working fine now. Also getting audio announcements in the drop-in UI. 🚀

@cammace cammace merged commit da3801e into master Oct 30, 2017
@cammace cammace deleted the extract-new-route-logic branch October 30, 2017 22:48
Grsmto pushed a commit to Grsmto/mapbox-navigation-android that referenced this pull request Oct 31, 2017
* master:
  Update adapter to remove current and upcoming steps from instruction list (mapbox#444)
  Show / hide recenter button when list is showing / hiding (mapbox#441)
  Removes duplicate check and adds test for new route (mapbox#443)
  Add extra space between destinations
  Changed turfhelper to turfconversion (mapbox#440)
@danesfeder danesfeder mentioned this pull request Nov 13, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants