Add telem absolute distance to destination track support #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
requested review from
zugaldia,
ericrwolfe,
electrostat and
danesfeder
Guardiola31337
force-pushed
the
pg-absolute-distance-to-destionation
branch
from
e47e283
to
3f0ae14
Compare
danesfeder
added
⚠️ DO NOT MERGE
* AbsoluteDistance Calculation * Connect Absolute Distance * Move to DistanceUtils
- Fixed conflicts - added method to handle final location from MetricsRouteProgress - passes local tests
danesfeder
suggested changes
Nov 10, 2017
There was a problem hiding this comment.
@electrostat Looking great - just two nit picks, then let's 🚀
| return finalManuever.location(); | ||
| } | ||
|
|
||
| return new Point() { |
There was a problem hiding this comment.
This can be simplified to return Point.fromLatLng(0d, 0d);
|
|
||
| public Point getDirectionsRouteDestination() { | ||
| StepManeuver finalManuever = directionsRoute.legs().get(directionsRoute.legs().size() - 1).steps() | ||
| .get(directionsRoute.legs().get(directionsRoute.legs().size() - 1).steps().size() - 1).maneuver(); |
There was a problem hiding this comment.
For readability, can we extract this into separate variables?
RouteLeg lastLeg = route.legs().get(route.legs().size() - 1);
LegStep lastStep = lastLeg.steps().get(lastLeg.steps().size() - 1);
StepManeuver finalManeuver = lastStep.maneuver();
- clean-up getDirectionsRouteDestination() - make more readable
danesfeder
approved these changes
Nov 10, 2017
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Nov 14, 2017
…android into fix-build * 'master' of https://github.com/mapbox/mapbox-navigation-android: Bumped version number to 0.7.0 in readme (mapbox#496) Release 0.7.0 (mapbox#497) Portrait / landscape layouts are different. Only cast to View (mapbox#494) Add missing javadoc for feedback methods in MapboxNavigation (mapbox#493) Update lane stylekit and then maneuver bias (mapbox#492) Fix bug with bottom sheet behavior null onConfigChange (mapbox#490) Fix issue where new route was not being detected (mapbox#478) Add telem absolute distance to destination track support (mapbox#427) Adjust Instruction Content Layout XML (mapbox#465) Fix bug with bottomsheet not hiding in night mode (mapbox#483) Cleanup / javadoc (mapbox#479) Initialize click listeners after presenter / viewmodel is set (mapbox#481) Create SpanUtil and SpanItem to more easily format Strings for our views (mapbox#477) Check for null or empty String speechUrl before playing (mapbox#475) Update location layer to 0.2.0 and re-add as lifecycle observer (mapbox#473) Check for null raw location before setting bearing (mapbox#476) # Conflicts: # libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationMetricsWrapper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
absoluteDistanceToDestinationtrack supportThis PR depends on mapbox/mapbox-java#615
TODO
0asabsoluteDistanceToDestination(placeholder), this needs to be taken fromRouteProgresssomehow.2.2.7) lands👀 @zugaldia @danesfeder @electrostat @ericrwolfe