Avoids out of bounds exception in addTrafficToSource() #384
Conversation
There was a problem hiding this comment.
@ericrwolfe can you link the ticket that's tracking this upstream? This is for sure a bug in the directions API and this if the if statement in this fix evaluates to false, no directions route will be drawn.
@zugaldia wondering if we should throw a runtime exception here so people know why the route line isn't being drawn.
@cammace @danesfeder if the directions request is invalid, we should just return the base directions route without any traffic, rather than not drawing any route as you've mentioned. Can we update? |
|
After talking with @danesfeder, I was wrong, this simply means it wouldn't draw the traffic. Should be good here. |
* Do not allow rotation for Nav UI (#377) * Support for multiple reroute metric collection (#348) * capture sessionState and add to queue when reroute occurs * Resolved several issues which related to location * fix checkstyle for NavigationMetricsWrapper * enable extra logging in debug mode * add option to log telemetry requests when debug mode is enabled * seconds no null anymore * make SessionState fields unique * add test for ringbuffer peak methods * create a copy of the location object when snapping a location * make sure the buffer keeps adding fresh values * Avoids out of bounds exception in addTrafficToSource() (#384) * avoids out of bounds exception * added index out of bounds exception * Undo throwing exception * force git to push * Updated changelog and readme * More reroute fixes (#389) * removed collection reverse * fix lastrerouteseconds * set the queued reroute events to represent new values * checkstyle * fixed total distance completed not getting set * make sure that the reroute event includes the reroute time as the created timestamp (#398) * temporarily change circle ci publish branch * [android] [auto] Update properties to version 0.6.3 in preparation for build. * change circleci script back to using master
Fixes #353.
cc: @cammace @danesfeder