Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace maneuver arrows and lanes #362

Merged
merged 9 commits into from
Oct 27, 2017
Merged

Replace maneuver arrows and lanes #362

merged 9 commits into from
Oct 27, 2017

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Oct 11, 2017

Fixes #265

This PR updates the maneuver arrows and lanes.

  • Add ManeuverStyleKit and ManeuverView.
  • Add LaneStyleKit and LaneView.
  • Remove all usages of the old manuever views, i.e. in the NavigationNotification.
  • Remove all vector drawables.

@danesfeder @cammace 👀

@frederoni frederoni changed the title Replace maneuver arrows Replace maneuver arrows and lanes Oct 11, 2017
@frederoni frederoni mentioned this pull request Oct 11, 2017
@ericrwolfe ericrwolfe added this to the v0.7.0 milestone Oct 12, 2017
@danesfeder
Copy link
Contributor

Moving to a new PR:

  • Add LaneStyleKit and LaneView.
  • Remove all usages of the old manuever views, i.e. in the NavigationNotification.
  • Remove all vector drawables.

@danesfeder danesfeder added bug Defect to be fixed. feature New feature request. and removed bug Defect to be fixed. labels Oct 27, 2017
@danesfeder danesfeder self-assigned this Oct 27, 2017
@danesfeder danesfeder merged commit 0f646c9 into master Oct 27, 2017
@danesfeder danesfeder deleted the fred-stylekit-views branch October 27, 2017 18:34
@ericrwolfe ericrwolfe mentioned this pull request Oct 27, 2017
3 tasks
@ericrwolfe
Copy link
Contributor

Tail work for lane views ticketed in #433

ericrwolfe added a commit that referenced this pull request Oct 27, 2017
@ericrwolfe ericrwolfe restored the fred-stylekit-views branch October 27, 2017 21:59
ericrwolfe added a commit that referenced this pull request Oct 27, 2017
danesfeder pushed a commit that referenced this pull request Oct 27, 2017
danesfeder added a commit that referenced this pull request Oct 27, 2017
* Add directions list to instruction view

* First pass at animating drop down directions

* Update click listener / animations based on port or landscape

* Use turn banner for directions list

* Handle back press while instruction list is visible

* Adjust reroute UI for landscape

* Create custom banner colors

* Adjust sound layout

* Revert "Replace maneuver arrows and lanes (#362)"

This reverts commit 0f646c9.

* Remove unnecessary map style attribute
Grsmto pushed a commit to Grsmto/mapbox-navigation-android that referenced this pull request Oct 30, 2017
…android into fix-build

* 'master' of https://github.com/mapbox/mapbox-navigation-android:
  Fixes issue with bearing values not matching the amount of coordinates passed with the new route request (mapbox#435)
  Feedback for Drop-In UI (mapbox#383)
  Directions List Dropdown (mapbox#415)
  fixed location object in snapToRoute (mapbox#434)
  add location engine class name as parameter of the different nav events builder methods (mapbox#401)
  Dynamic reroute tolerance method (mapbox#428)
  Replace maneuver arrows and lanes (mapbox#362)

# Conflicts:
#	libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationMetricsWrapper.java
@danesfeder danesfeder deleted the fred-stylekit-views branch October 31, 2017 19:18
@danesfeder danesfeder mentioned this pull request Nov 13, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants