Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-in UI Theme Switching #286

Merged
merged 22 commits into from
Oct 5, 2017
Merged

Drop-in UI Theme Switching #286

merged 22 commits into from
Oct 5, 2017

Conversation

danesfeder
Copy link
Contributor

@danesfeder danesfeder commented Sep 29, 2017

Note: currently branched from rotation PR

Remaining Todo:

  • Dark theme colors
  • Extract constants
  • Text colors
  • < API 19 set colors without ?attr
  • javadoc

@danesfeder
Copy link
Contributor Author

danesfeder commented Oct 2, 2017

Found that the crash we are seeing in API 19 was related to using custom attributes when setting the Drawable colors.

Created v21 versions of the drawables with the attributes included then added version checks to set the drawable colors based on the given style if the API is lower than 21.

Still TODO: setting the color of the recenter btn / progress bar

@danesfeder
Copy link
Contributor Author

ezgif com-video-to-gif

- Add light / dark marker
@cammace
Copy link

cammace commented Oct 3, 2017

Is it possible to keep the navigation puck facing the correct orientation? Can we open a ticket in the plugins repo if this is something that should be fixed inside that library? Otherwise, this looks awesome!

@danesfeder
Copy link
Contributor Author

danesfeder commented Oct 3, 2017

@cammace I'm pretty sure this is only because of the MockLocationEngine restarting and shouldn't be an issue with actual engines

@danesfeder danesfeder merged commit 7a1cbee into master Oct 5, 2017
@danesfeder danesfeder deleted the dan-theme-switcher branch October 5, 2017 14:31
@Danny-James
Copy link

Danny-James commented Oct 6, 2017

@danesfeder quick question, when these fixes are made, how do i know what i need to compile to get them/where do i find the latest version?

As I'm compling with the following:

    compile 'com.mapbox.mapboxsdk:mapbox-android-navigation:0.7.0-SNAPSHOT'
    compile 'com.mapbox.mapboxsdk:mapbox-android-navigation-ui:0.7.0-SNAPSHOT'

I don't seem to have these changes - I've removed any cached files and they have re-downloaded.

@cammace cammace mentioned this pull request Oct 7, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants