Removed multiple instantiations of MapboxOfflineRouter from OfflineRegionDownloadActivity #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gionDownloadActivity and replaced with class field
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
=========================================
Coverage 26.69% 26.69%
Complexity 823 823
=========================================
Files 202 202
Lines 8533 8533
Branches 627 627
=========================================
Hits 2278 2278
Misses 6042 6042
Partials 213 213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed multiple instantiations of MapboxOfflineRouter from OfflineRegionDownloadActivity and replaced with class field so that we can encourage developers to use a single instance of
MapboxOfflineRouterat a time.