Fix AlertView animation leak #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1667 +/- ##
===========================================
+ Coverage 26.21% 26.3% +0.08%
- Complexity 787 790 +3
===========================================
Files 196 197 +1
Lines 8342 8345 +3
Branches 598 598
===========================================
+ Hits 2187 2195 +8
+ Misses 5958 5952 -6
- Partials 197 198 +1 |
danesfeder
force-pushed
the
dan-alert-leak
branch
4 times, most recently
from
ba915e7 to
15daa64
Compare
| @@ -62,6 +62,7 @@ protected void onFinishInflate() { | |||
| protected void onDetachedFromWindow() { | |||
| super.onDetachedFromWindow(); | |||
| if (countdownAnimation != null) { | |||
| countdownAnimation.removeAllListeners(); | |||
There was a problem hiding this comment.
I've tested this and it's not being called because countdownAnimation is null when onDetachedFromWindow is called - causing the leak.
I believe best approach here is bring the WeakReference back and remove onDetachedFromWindow code.
danesfeder
force-pushed
the
dan-alert-leak
branch
from
15daa64 to
1f5fe7b
Compare
|
@Guardiola31337 thanks for testing that out, I updated the code to reflect your recommendations 🚀 |
danesfeder
force-pushed
the
dan-alert-leak
branch
from
1f5fe7b to
ce7d83d
Compare
danesfeder
force-pushed
the
dan-alert-leak
branch
from
ce7d83d to
a4b1090
Compare
Guardiola31337
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
Still wondering how / where we should cancel the animation and remove the listener previously added
AlertView a WeakReference but for now it's working and couldn't reproduce the leak anymore 🎉 We can revisit later.
Thanks @danesfeder for addressing the feedback 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Guardiola31337 spotted this leak when testing 👁:
It seems this is reproducible when closing the
NavigationViewwhile theAlertViewis still showing / animating. I wasn't able to reproduce with thew newWeakReference.We also have an existing check to cancel the animation when the
AlertViewis detached from the window.