Fix route requests that include waypoint names #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
bug
danesfeder
force-pushed
the
dan-remaining-waypointnames
branch
2 times, most recently
from
43075ba
to
870acb6
Compare
|
Tests added, this is ready for 👀 @Guardiola31337 @devotaaabel |
danesfeder
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
danesfeder
force-pushed
the
dan-remaining-waypointnames
branch
from
870acb6
to
7462203
Compare
Guardiola31337
approved these changes
Sep 7, 2018
danesfeder
force-pushed
the
dan-remaining-waypointnames
branch
from
7462203
to
a6b8342
Compare
| public String[] calculateRemainingWaypointNames(RouteProgress routeProgress) { | ||
| RouteOptions routeOptions = routeProgress.directionsRoute().routeOptions(); | ||
| if (routeOptions == null || TextUtils.isEmpty(routeOptions.waypointNames())) { | ||
| return null; |
There was a problem hiding this comment.
We should consider returning a Null Object instead or even better try to getting rid of it at all (maybe returning an empty list?). If not, code becomes defensive and full of null checks.
| * @since 0.19.0 | ||
| */ | ||
| @Nullable | ||
| public String[] calculateRemainingWaypointNames(RouteProgress routeProgress) { |
There was a problem hiding this comment.
If this is only used in RouteFetcher#addWaypointNames why we need to expose it as a public API here in RouteUtils?
IMO, objects and methods should live/be where their context is. From my experience utility classes become a drawer easily and we should treat them carefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1160
TODO:
RouteUtilstest