Do not add Fragments to backstack in FragmentNavigationActivity #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
Changes look good to me 🚀
While testing I found that the FAB doesn't survive rotation 👀
Feel free to fix as part of this PR. If not, we should cut a different ticket.
Thanks @danesfeder
danesfeder
force-pushed
the
dan-fragment-backstack
branch
from
4c57b7b
to
d273219
Compare
|
@Guardiola31337 visibility of fab fixed in latest push |
Awesome 🎉 Thanks for the quick fix 🙏 |
danesfeder
force-pushed
the
dan-fragment-backstack
branch
from
d273219
to
261b763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1244