Retrieve feedback Strings from Resources #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danesfeder
force-pushed
the
dan-feedback-strings
branch
4 times, most recently
from
cebd03d to
0962761
Compare
danesfeder
force-pushed
the
dan-feedback-strings
branch
from
0962761 to
a9345c0
Compare
|
Noting here that we should 👀 in Transifex the translated strings that include control characters (e.g. new line |
Guardiola31337
approved these changes
Aug 6, 2018
There was a problem hiding this comment.
Noting here that we should 👀 in Transifex the translated strings that include control characters (e.g. new line
\n) before accepting them. That's not the case forfeedback_not_allowedGerman translation (Nicht erlaubt).
We should check next time that we pull down the latest translations from Transifex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1193