Add ETA support for the notification back #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
reviewed
Aug 3, 2018
| @@ -187,8 +190,9 @@ private void updateArrivalTime(RouteProgress routeProgress) { | |||
| double durationRemaining = routeProgress.durationRemaining(); | |||
| int timeFormatType = options.timeFormatType(); | |||
| String arrivalTime = formatTime(time, durationRemaining, timeFormatType, isTwentyFourHourFormat); | |||
| collapsedNotificationRemoteViews.setTextViewText(R.id.notificationArrivalText, arrivalTime); | |||
| expandedNotificationRemoteViews.setTextViewText(R.id.notificationArrivalText, arrivalTime); | |||
| String formattedArrivalText = String.format(Locale.getDefault(), etaFormat, arrivalTime); | |||
There was a problem hiding this comment.
Would it be better to get the Configuration Locale using LocaleUtils here? We can do this during initialize. I believe we are doing this everywhere else within the SDK, so it would be great to stay consistent.
Guardiola31337
force-pushed
the
pg-notification-eta
branch
from
a5ea26c
to
464c2da
Compare
danesfeder
approved these changes
Aug 3, 2018
Guardiola31337
force-pushed
the
pg-notification-eta
branch
from
464c2da
to
1d24f07
Compare
Guardiola31337
force-pushed
the
pg-notification-eta
branch
from
1d24f07
to
f3b4271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1115 we removed the ETA from
arrivalTimeinMapboxNavigationNotificationby mistake.This PR brings that functionality back.