Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use application Context for CustomNavigationNotification example #1182

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Use application Context for CustomNavigationNotification example #1182

merged 1 commit into from
Aug 3, 2018

Conversation

danesfeder
Copy link
Contributor

Fixes #1131

@danesfeder danesfeder added bug Defect to be fixed. ✓ ready for review labels Aug 2, 2018
@danesfeder danesfeder added this to the 0.17.0 milestone Aug 2, 2018
@danesfeder danesfeder self-assigned this Aug 2, 2018
Guardiola31337
Guardiola31337 approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@danesfeder danesfeder merged commit 2c09d73 into master Aug 3, 2018
@danesfeder danesfeder deleted the dan-custom-notificaton-leak branch August 3, 2018 14:01
@Guardiola31337 Guardiola31337 mentioned this pull request Aug 10, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

@devotaaabel devotaaabel Awaiting requested review from devotaaabel

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @Guardiola31337