Check dispatcher on announcement and instruction events in ViewModel #1152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in CI:
These
NavigationViewDispatcherEvents
were added in #1107 and were not accompanied with a null check. Every time we use the dispatcher inNavigationViewModel
we need to double check it isn'tnull
because we set it tonull
during rotation to prevent leaks from theNavigationView
being destroyed.