Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent route overview animation with insufficient route data #1120

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Prevent route overview animation with insufficient route data #1120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...i/src/main/java/com/mapbox/services/android/navigation/ui/v5/camera/NavigationCamera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
public class NavigationCamera implements LifecycleObserver {

private static final long MAX_ANIMATION_DURATION_MS = 1500;
private static final int ONE_POINT = 1;

private MapboxMap mapboxMap;
private MapboxNavigation navigation;
Expand Down Expand Up @@ -300,6 +301,9 @@ private void animateCameraForRouteOverview(RouteInformation routeInformation, in
}

private void animateMapboxMapForRouteOverview(int[] padding, List<Point> routePoints) {
if (routePoints.size() <= ONE_POINT) {
return;
}
CameraUpdate resetUpdate = buildResetCameraUpdate();
final CameraUpdate overviewUpdate = buildOverviewCameraUpdate(padding, routePoints);
mapboxMap.animateCamera(resetUpdate, 150,
Expand Down