Provide example of showing and hiding Fragment with NavigationView #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
force-pushed
the
dan-second-init
branch
2 times, most recently
from
5c745a7
to
7dde094
Compare
| @@ -258,6 +260,7 @@ private void addMilestones(NavigationViewOptions options) { | |||
| private ProgressChangeListener progressChangeListener = new ProgressChangeListener() { | |||
| @Override | |||
| public void onProgressChange(Location location, RouteProgress routeProgress) { | |||
| Timber.d("NAV_DEBUG - onProgressChange"); | |||
There was a problem hiding this comment.
I imagine this slipped in by mistake (debugging purposes). We should remove this log.
Guardiola31337
approved these changes
Aug 3, 2018
danesfeder
force-pushed
the
dan-second-init
branch
3 times, most recently
from
8d32915
to
1c74b36
Compare
danesfeder
force-pushed
the
dan-second-init
branch
from
1c74b36
to
c4f9013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1109
This PR iterates on the
Fragmentexample we provide in the test app. Now we demonstrate how to show / hide aFragmentinflating aNavigationViewwith aFragmentTransaction.