Add dual navigation map example to the test app #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
force-pushed
the
pg-dual-map-navigation-activity
branch
2 times, most recently
from
77bda2b
to
d0a77fe
Compare
|
Noticed the flashing issue #800 while testing OP 👀
|
|
Also noticed that the camera doesn't center properly after expanding 👀
|
|
Also noticed that the sound and feedback buttons don't scale 👀
|
|
This is ready for review 👀 I'll cut new tickets for the shown issues after merging. |
danesfeder
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
@Guardiola31337 this is a great example showing some of the more advanced customization abilities of NavigationView. Thanks for running with this, I don't have any feedback. 🚢
…ayout version to 1.1.1
Guardiola31337
force-pushed
the
pg-dual-map-navigation-activity
branch
from
d0a77fe
to
88f00b9
Compare
This was referenced Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DualNavigationMapActivityto the test app which shows how to addNavigationViewandMapViewin the same layout and allows us to test Add end navigation functionality to navigation view #959 (comment)constraint-layoutversion to1.1.1