Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MapView id included in NavigationView #1087

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Rename MapView id included in NavigationView #1087

merged 1 commit into from
Jul 5, 2018

Conversation

Guardiola31337
Copy link
Contributor

  • Refactor renames MapView id included in NavigationView from mapView to navigationMapView to avoid clashes when including NavigationView and MapView in the same layout

@Guardiola31337
refactor rename map view id included in navigation view from mapView …
68afaf0 
…to navigationMapView to avoid clashes when including navigation view and map view in the same layout
@Guardiola31337 Guardiola31337 self-assigned this Jul 5, 2018
danesfeder
danesfeder approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Guardiola31337 Guardiola31337 merged commit d09ec1f into master Jul 5, 2018
@Guardiola31337 Guardiola31337 deleted the pg-navigation-map-view-clash branch July 5, 2018 16:39
@danesfeder danesfeder mentioned this pull request Jul 20, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danesfeder danesfeder danesfeder approved these changes

Assignees

@Guardiola31337 Guardiola31337

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guardiola31337 @danesfeder