Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector drawables for < API 21 in test Application #1067

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

danesfeder
Copy link
Contributor

Vector drawables were causing a android.content.res.Resources$NotFoundException on devices < API 21

Does it make sense to do this for the developer in NavigationView? 🤔

@danesfeder danesfeder added bug Defect to be fixed. navigation-ui labels Jun 27, 2018
@danesfeder danesfeder added this to the 0.16.0 milestone Jun 27, 2018
@danesfeder danesfeder self-assigned this Jun 27, 2018
@Guardiola31337 Guardiola31337 force-pushed the dan-vector-fix branch 3 times, most recently from 511eacc to 200e7ca Compare June 29, 2018 16:20
@Guardiola31337
Copy link
Contributor

Found a solution to solve OP's exception (using AppCompatResources instead of ContextCompat to getDrawables) that doesn't need to add

static {
    AppCompatDelegate.setCompatVectorFromResourcesEnabled(true);
}

in the test app and also removes 👇 concern

Does it make sense to do this for the developer in NavigationView? 🤔

Per chat with @danesfeder I went ahead and reverted his changes and rebased mine.

This is ready for review 👀

@danesfeder
Copy link
Contributor Author

@Guardiola31337 great catch here - thanks for the work to update. Looks good to me ✅

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Self" approving 😂

Thanks @danesfeder

@danesfeder danesfeder merged commit 1225a25 into master Jun 29, 2018
@danesfeder danesfeder deleted the dan-vector-fix branch June 29, 2018 16:51
@danesfeder danesfeder mentioned this pull request Jul 20, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants