Update NavigationActivity naming to avoid naming collisions #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Jun 14, 2018
danesfeder
force-pushed
the
dan-navigation-activity-naming
branch
from
9e0936e
to
a6ee3a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #998
If a user of
libandroid-navigation-uicreates their ownActivityand names itNavigationActivity, the naming collides with theNavigationActivitywe bundle for use withNavigationLauncher.This PR updates the naming of
NavigationActivity>MapboxNavigationActivityto make the naming more specific to the SDK.