Remove duplicate ViewModel updates (#647)

mapbox · Jan 10, 2018 · 312dde8 · 312dde8
1 parent fec78bc
commit 312dde8
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/...igation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/NavigationView.java b/...igation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/NavigationView.java
@@ -349,18 +349,14 @@ public void startNavigation(NavigationViewOptions options) {
       // Initialize the camera (listens to MapboxNavigation)
       initCamera();
       setupListeners(options);
-      // Update the view models
-      locationViewModel.updateShouldSimulateRoute(options.shouldSimulateRoute());
-      routeViewModel.extractRouteOptions(options);
       // Everything is setup, subscribe to the view models
       subscribeViewModels();
       // Initialized and navigating at this point
       isInitialized = true;
-    } else {
-      // Only need to update the view models
-      locationViewModel.updateShouldSimulateRoute(options.shouldSimulateRoute());
-      routeViewModel.extractRouteOptions(options);
     }
+    // Update the view models
+    locationViewModel.updateShouldSimulateRoute(options.shouldSimulateRoute());
+    routeViewModel.extractRouteOptions(options);
   }
 
   /**