add getting mapmatching through POST method #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osana
force-pushed
the
osana-map-maptching-post
branch
from
15dabc7 to
3cc596f
Compare
osana
force-pushed
the
osana-map-maptching-post
branch
from
3cc596f to
d90e3ed
Compare
There was a problem hiding this comment.
I've left a couple of minor comments. Other than that this looks good to me 👍
Thanks @osana for adding the POST support to the Map Matching API.
|
|
||
|
|
||
| /** | ||
| * Constructs the POSt call using the information passed in through the |
There was a problem hiding this comment.
Minor thing - Typo *POSt instead of POST
| */ | ||
| @FormUrlEncoded | ||
| @POST("matching/v5/{user}/{profile}") | ||
| Call<MapMatchingResponse> getPostCall( |
There was a problem hiding this comment.
Isn't the get in
GET request? If so, should we name this method postCall instead?
osana
force-pushed
the
osana-map-maptching-post
branch
2 times, most recently
from
40d0001 to
daeb546
Compare
| @@ -338,6 +364,28 @@ public static Builder builder() { | |||
| private String[] waypointNames; | |||
| private String[] approaches; | |||
|
|
|||
| /** | |||
| * Use GET method to request data (default). | |||
There was a problem hiding this comment.
Minor comment - Shouldn't this be POST instead of GET? It seems it got reversed with the get method below 👇
osana
force-pushed
the
osana-map-maptching-post
branch
from
daeb546 to
10c9a53
Compare
osana
force-pushed
the
osana-map-maptching-post
branch
from
10c9a53 to
236b4e4
Compare
Guardiola31337
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
This is looking good 🚀
Thanks for addressing the feedback @osana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #947