Added waypoint targets to MapboxDirections request #942
Conversation
osana
force-pushed
the
osana-waypoint-target
branch
2 times, most recently
from
2be226c to
c01a7a0
Compare
There was a problem hiding this comment.
Thanks for the quick fix here, this is looking great @osana 👍
I left some minor comments.
@danpaz confirmed that the first coordinate is ignored (for now) so accepts: any coordinate, empty (;) or null) but mentioned that in the future the first waypoint_target could provide guidance to the starting point of the route. Should we document / add a comment in Javadoc clarifying this?
| @@ -47,6 +47,7 @@ | |||
| * @param exclude exclude tolls, motorways or more along your route | |||
| * @param approaches which side of the road to approach a waypoint | |||
| * @param waypointNames custom names for waypoints used for the arrival instruction. | |||
| * @param waypointTargets list of coordinate pairs for drop-off locations . | |||
There was a problem hiding this comment.
NIT - Typo extra space before the .
| } | ||
|
|
||
| /** | ||
| * Converts array of Points with waypoint_names values |
There was a problem hiding this comment.
NIT - Typo *waypoint_names should be waypoint_targets
| @@ -725,6 +755,23 @@ public Builder addWaypointNames(@Nullable String... waypointNames) { | |||
|
|
|||
| abstract Builder waypointNames(@Nullable String waypointNames); | |||
|
|
|||
| /** | |||
| * A list of coordinate points used to specify drop-off locations | |||
| * that are distinct from the locations specified in coordinates. | |||
There was a problem hiding this comment.
NIT - Typo extra space in *in coordinates.
| /** | ||
| * A list of coordinate points used to specify drop-off locations | ||
| * that are distinct from the locations specified in coordinates. | ||
| * The number of waypoint targets must be the same as the number of coordinates, |
| * Must be used with steps=true . | ||
| * @param waypointTargets list of coordinate points for drop-off locations | ||
| * @return this builder for chaining options together | ||
| * @since 4.2.0 |
There was a problem hiding this comment.
Typo - NIT *4.2.0 should be 4.3.0
| * A semicolon-separated list of coordinate pairs used to specify drop-off | ||
| * locations that are distinct from the locations specified in coordinates. | ||
| * If this parameter is provided, the Directions API will compute the side of the street, | ||
| * left or right, for each target based on the waypoint_targets and the driving direction. |
There was a problem hiding this comment.
NIT - Typo extra space in *on the waypoint_targets
| * locations that are distinct from the locations specified in coordinates. | ||
| * If this parameter is provided, the Directions API will compute the side of the street, | ||
| * left or right, for each target based on the waypoint_targets and the driving direction. | ||
| * The maneuver.modifier , banner and voice instructions will be updated with the computed |
There was a problem hiding this comment.
Same here ☝️ *The maneuver.modifier , and list with the ;
There was a problem hiding this comment.
Thanks for the quick work on this @osana - I have no feedback other than what @Guardiola31337 has already pointed out. 🚢
Guardiola31337
force-pushed
the
osana-waypoint-target
branch
from
c01a7a0 to
eb8890f
Compare
Guardiola31337
force-pushed
the
osana-waypoint-target
branch
from
eb8890f to
8d384f6
Compare
|
I went ahead and fix above comments myself so we can 🚀 I hope that was ok with you @osana 🙏 |
closes #939