Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated optimization API #506

Merged
merged 3 commits into from
Jul 18, 2017
Merged

Updated optimization API #506

merged 3 commits into from
Jul 18, 2017

Conversation

cammace
Copy link
Contributor

@cammace cammace commented Jul 14, 2017 •
edited
Loading

This PR fixes a number of issues with the Optimization API:

  • Fixes getRadius() method which wasn't being converted to a string.
  • Fixes getBearing() method which wasn't being converted to a string.
  • Adds support for language parameter
  • Adds support for distributions parameter
  • Adds missing waypoint_index inside the DirectionsWaypoint class.
  • Deprecates annotation in favor of the correct name annotations

@cammace cammace self-assigned this Jul 14, 2017
@cammace cammace requested a review from zugaldia July 14, 2017 01:31
@cammace cammace mentioned this pull request Jul 14, 2017
Closed
@cammace cammace added this to the v2.2.0 milestone Jul 14, 2017
@cammace cammace force-pushed the cam-optimization branch from dfd079a to a7a0033 Compare July 18, 2017 16:25
@cammace cammace merged commit c89a062 into master Jul 18, 2017
@cammace cammace deleted the cam-optimization branch July 18, 2017 17:02
@cammace cammace mentioned this pull request Jul 20, 2017
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugaldia zugaldia zugaldia approved these changes

Assignees

@cammace cammace

Labels
Feature Ready For Review
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cammace @zugaldia