Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split MAS into smaller submodules #251

Merged
merged 34 commits into from
Jan 5, 2017
Merged

Split MAS into smaller submodules #251

merged 34 commits into from
Jan 5, 2017

Conversation

zugaldia
Copy link
Member

@zugaldia zugaldia commented Jan 4, 2017

This PR brings the following changes to MAS:

  • libjava and libandroid now live under the same (Android Studio) project.
  • These projects are now split up into: libjava-core, libjava-geojson, libjava-services, libjava-services-rx, libandroid-telemetry, libandroid-services, libandroid-ui, and app.
  • All but app will be published independently to Maven.
  • No code has been changed, except to adjust package names (which I've tried to respect the best I could).

Pending:

  • libjava-services-rx (see Support RxJava #131) and libandroid-telemetry are placeholders for now.
  • Port all gradle settings (like publish to Maven Central, checkstyle).
  • Update CI (Bitrise settings)

@mapbox/android Still a WIP but open for feedback.

@zugaldia
Copy link
Member Author

zugaldia commented Jan 5, 2017

Alright, everything should be working now like before.

@tobrun @cammace great if I could get your 👀 here. I know this is a massive PR, but great if at least you can detect red flags now, we can polish the rest later in separate tickets. There are no changes to code, just to the organization of the packages into more and smaller submodules. If it helps, I just published SNAPSHOTS for all the modules and they're available on https://oss.sonatype.org/content/repositories/snapshots/com/mapbox/mapboxsdk/ (no actual releases on Maven yet).

  • libandroid-services: Equivalent to the previous android-services.
  • libandroid-telemetry: Future container for extracted telemetry.
  • libandroid-ui: UI components, for now, just the Geocoder Autocomplete.
  • libjava-core: Just models.
  • libjava-geojson: So that the SDK doesn't need to include code it doesn't need for the Runtime Styling implementation.
  • libjava-services: Equivalent to the previous java-services.
  • libjava-services-rx: RxJava extensions (to bring them back)

libjava-services-rx and libandroid-telemetry will be tackled in a separate ticket.

Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Works successfully in the demo app

@zugaldia zugaldia changed the title [WIP] Split MAS into smaller submodules Split MAS into smaller submodules Jan 5, 2017
@zugaldia zugaldia merged commit dfebb06 into master Jan 5, 2017
@zugaldia zugaldia deleted the mas-split branch January 5, 2017 21:10
This was referenced Feb 7, 2017
@zugaldia zugaldia mentioned this pull request Feb 22, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 9, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 17, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants