-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split MAS into smaller submodules #251
Conversation
…e and gradle-mvn-push-java.gradle to avoid overlap
Alright, everything should be working now like before. @tobrun @cammace great if I could get your 👀 here. I know this is a massive PR, but great if at least you can detect red flags now, we can polish the rest later in separate tickets. There are no changes to code, just to the organization of the packages into more and smaller submodules. If it helps, I just published SNAPSHOTS for all the modules and they're available on https://oss.sonatype.org/content/repositories/snapshots/com/mapbox/mapboxsdk/ (no actual releases on Maven yet).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Works successfully in the demo app
This PR brings the following changes to MAS:
libjava
andlibandroid
now live under the same (Android Studio) project.libjava-core
,libjava-geojson
,libjava-services
,libjava-services-rx
,libandroid-telemetry
,libandroid-services
,libandroid-ui
, andapp
.app
will be published independently to Maven.Pending:
libjava-services-rx
(see Support RxJava #131) andlibandroid-telemetry
are placeholders for now.@mapbox/android Still a WIP but open for feedback.