Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding and adjusting repo issue templates #1069

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

langsmith
Copy link

This pr adjusts and adds to the issue template folder in this repo. #1024 has a fleshed-out release checklist, which explains how to tie Java releases into the Maps/Navigation SDKs. I figured it'd be good to have the checklist as a formal issue template.

cc @mapbox/maps-android

@langsmith langsmith self-assigned this Sep 4, 2019
@langsmith langsmith force-pushed the ls-adding-release-ticket-checklist-template branch 2 times, most recently from 5300c15 to 4c08f6b Compare September 4, 2019 22:49
@langsmith
Copy link
Author

Don't review yet. We need to figure out ideal process. Release should be done via Github tags, right?

Creating https://github.com/mapbox/mapbox-java/releases/tag/v4.9.0-alpha.1 didn't kickstart the CircleCI release job.

I guess because of https://github.com/mapbox/mapbox-java/blob/master/circle.yml#L48-L49. Should https://github.com/mapbox/mapbox-java/blob/master/circle.yml#L48-L49 be changed to only [[ $CIRCLE_TAG == v* ]] ?

To get 4.9.0-alpha.1 to Bintray, I had to change mentions of master to my release branch name in circle.yml.

@langsmith langsmith force-pushed the ls-adding-release-ticket-checklist-template branch from 4c08f6b to 75d75e9 Compare September 5, 2019 00:00
@LukasPaczos
Copy link
Contributor

@langsmith checkout those PRs I made a couple of weeks ago adjusting the mapbox-gestures-android to be bintray/tag-release compatible because I see mapbox-java is going to suffer from similar issues:

@langsmith langsmith force-pushed the ls-adding-release-ticket-checklist-template branch from 75d75e9 to 137e6ee Compare September 5, 2019 19:01
@langsmith langsmith force-pushed the ls-adding-release-ticket-checklist-template branch from 5590661 to 38c2302 Compare September 25, 2019 00:46
@langsmith langsmith force-pushed the ls-adding-release-ticket-checklist-template branch from 38c2302 to 3a8386c Compare October 4, 2019 20:34
@langsmith
Copy link
Author

Ok @LukasPaczos , this is ready for another round of 👀

Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/ISSUE_TEMPLATE/java-stable-release-template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/java-stable-release-template.md Outdated Show resolved Hide resolved
@langsmith langsmith force-pushed the ls-adding-release-ticket-checklist-template branch from a89efb4 to 4777b06 Compare October 8, 2019 16:46
@langsmith langsmith merged commit 9bd6158 into master Oct 8, 2019
@langsmith langsmith deleted the ls-adding-release-ticket-checklist-template branch October 8, 2019 17:04
@langsmith langsmith mentioned this pull request Jan 8, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants