Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename references of mapIds to tileSetIds #1047

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Rename references of mapIds to tileSetIds #1047

merged 3 commits into from
Jan 8, 2020

Conversation

langsmith
Copy link

Resolves #1021 by refactoring references of mapIds to tileSetIds. This pr is the same as #1022, but like this pr, #1022 was semver major and shouldn't have been merged just yet. #1022 was reverted, so this pr sets up the original refactoring changes for eventual merge to master.

@langsmith langsmith force-pushed the ls-update-of-mapID-references-to-tile-ID branch 2 times, most recently from dbc816f to 4aef630 Compare June 12, 2019 17:19
@langsmith langsmith requested a review from tobrun June 14, 2019 16:12
@langsmith langsmith self-assigned this Jun 14, 2019
@zugaldia
Copy link
Member

@langsmith @tobrun Considering that the changes only affect the TileQuery component, it should be possible to update Maps SDK without breaking its public APIs. Does that sound correct?

@langsmith
Copy link
Author

Yea, that's correct @zugaldia .

@HeyStenson
Copy link
Contributor

Thanks for your help on this @langsmith! 🙌 Turns out there were only two little changes that needed to be made.

@stale stale bot added the Archived Issue archived due to lack of activity label Sep 10, 2019
@stale
Copy link

stale bot commented Sep 10, 2019

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this Sep 10, 2019
@tobrun tobrun reopened this Sep 11, 2019
@stale stale bot removed the Archived Issue archived due to lack of activity label Sep 11, 2019
@HeyStenson
Copy link
Contributor

@langsmith Do we need to do anything else to get this over the finish line?

@langsmith
Copy link
Author

Waiting @HeyStenson 😕 . This pr has semver major changes, so I've thought that we'll do a SEMVER major Java release when we do our next Maps SDK SEMVER major release.

@langsmith langsmith added this to the v5.0.0 milestone Sep 25, 2019
@stale stale bot added the Archived Issue archived due to lack of activity label Nov 24, 2019
@stale
Copy link

stale bot commented Nov 24, 2019

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this Nov 24, 2019
@langsmith langsmith reopened this Nov 25, 2019
@stale stale bot removed the Archived Issue archived due to lack of activity label Nov 25, 2019
@langsmith langsmith force-pushed the ls-update-of-mapID-references-to-tile-ID branch from 5b3cdee to ed2bc89 Compare January 8, 2020 21:49
@langsmith langsmith force-pushed the ls-update-of-mapID-references-to-tile-ID branch from ed2bc89 to b970425 Compare January 8, 2020 23:21
@langsmith langsmith merged commit d5d5b4f into master Jan 8, 2020
@langsmith langsmith deleted the ls-update-of-mapID-references-to-tile-ID branch January 8, 2020 23:36
@langsmith langsmith mentioned this pull request Jan 8, 2020
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees

@langsmith langsmith

Labels
⚠️ DO NOT MERGE refactor SEMVER-MAJOR Tilequery
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

Rename map IDs to tileset identifiers
4 participants
@langsmith @zugaldia @HeyStenson @tobrun