Adding explode turf method #1007
Conversation
langsmith
force-pushed
the
ls-adding-turf-explode-method
branch
3 times, most recently
from
c95c4c1 to
12d807c
Compare
|
@osana , for some reason, the test wouldn't accept my fixture for That's why I'm building those object in a different way for now:
Is there something I'm doing wrong, which is preventing me from doing Also, https://github.com/mapbox/mapbox-java/pull/1007/files#diff-b6a32aa24e73a2791a14203a75659fce is in this pr because it was invalid GeoJSON. It needed |
services-turf/src/main/java/com/mapbox/turf/TurfConversion.java
Outdated
Show resolved
Hide resolved
| * @since 4.7.0 | ||
| */ | ||
| private static FeatureCollection explode(@NonNull Geometry geometry) { | ||
| List<Feature> featuresForFinalFeatureCollection = new ArrayList<>(); |
There was a problem hiding this comment.
Looks like there is a method:
https://turfjs.org/docs/#coordAll
that is supposed to work for FeatureCollection/Feature and Geometry.
We ported only the Geometry parameter.
What do you think if we port coordAll(FeatureCollection) and coordAll(Feature) and then take advantage of it here.
There was a problem hiding this comment.
What do you think if we port coordAll(FeatureCollection) and coordAll(Feature) and then take advantage of it here.
Yea, I think we should do this. I've needed it a bunch during my work on porting more methods to Turf for Java.
There was a problem hiding this comment.
Yea, I think we should do this.
langsmith
force-pushed
the
ls-adding-turf-explode-method
branch
2 times, most recently
from
7a22877 to
8228322
Compare
langsmith
force-pushed
the
ls-adding-turf-explode-method
branch
from
8228322 to
eb524ca
Compare
This pr ports the explode method to Turf for Java. This method takes a
FeatureorFeatureCollectionand returns aFeatureCollectionofPointobjects which represent all of the positions in that originalFeature/FeatureCollectionparameter.http://turfjs.org/docs/#explode
https://github.com/Turfjs/turf/blob/master/packages/turf-explode/index.js
explode(FeatureCollection featureCollection)&explode(Feature feature)are the new methods added in theTurfConversionclass.