Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BoundingBoxPolygon turf method #1006

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

langsmith
Copy link

This pr ports the bboxPolygon method to Turf for Java.

http://turfjs.org/docs/#bboxPolygon

https://github.com/Turfjs/turf/blob/master/packages/turf-bbox-polygon/index.ts

bboxPolygon(BoundingBox boundingBox) is now a new method in the TurfMeasurement class

Used the geojson.io website during my work to test that the Polygon object returned by bboxPolygon(BoundingBox boundingBox), is valid and correct:

Screen Shot 2019-04-17 at 9 45 54 AM

Screen Shot 2019-04-17 at 9 46 02 AM

Screen Shot 2019-04-17 at 10 08 10 AM

Screen Shot 2019-04-17 at 10 07 53 AM

@langsmith langsmith requested a review from osana April 17, 2019 17:45
@langsmith langsmith self-assigned this Apr 17, 2019
@langsmith langsmith force-pushed the ls-adding-boundingbox-polygon-turf-method branch from fa7d9f5 to 170727d Compare April 17, 2019 22:11
Copy link
Contributor

@osana osana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for running with this!
One minor comment below.

@langsmith langsmith force-pushed the ls-adding-boundingbox-polygon-turf-method branch from 170727d to 4ddeef1 Compare April 18, 2019 14:19
@langsmith langsmith force-pushed the ls-adding-boundingbox-polygon-turf-method branch 2 times, most recently from 103f01d to de27fd8 Compare April 18, 2019 18:26
@langsmith langsmith force-pushed the ls-adding-boundingbox-polygon-turf-method branch from de27fd8 to ee082ad Compare April 18, 2019 18:45
@osana osana added this to the v4.7.0 milestone Apr 18, 2019
@langsmith langsmith merged commit 9c390ff into master Apr 18, 2019
@langsmith langsmith deleted the ls-adding-boundingbox-polygon-turf-method branch April 18, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants