New awesome image comparison using pixelmatch #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to up my game so I can use "awesome" in my PRs, too. Rock on, @mourner. 🎸 |
Checked this, the reference image for geojson test does not visually change when I update it, so the difference in CI is something else. |
|
@friedbunny just add the word "awesome" to your every PR, it's a daily autosuggestion ritual :) |
friedbunny
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Oct 28, 2015
Drops mason-installed packages Boost, zlib, libpng, libuv and glfw. Adds libtool and automake, which may be needed when mason binaries are not available. Drops ImageMagick, which was replaced with pixelmatch in aaf090b & mapbox/mapbox-gl-test-suite#50
AndwareSsj
pushed a commit
to AndwareSsj/mapbox-gl-native
that referenced
this pull request
Nov 6, 2015
Drops mason-installed packages Boost, zlib, libpng, libuv and glfw. Adds libtool and automake, which may be needed when mason binaries are not available. Drops ImageMagick, which was replaced with pixelmatch in aaf090b & mapbox/mapbox-gl-test-suite#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the test suite many times more awesome and useful by ditching ImageMagick in favor of my new pixelmatch library. Closes #24.
Take a look at the example output and compare that with the current one.
cc @mapbox/gl