This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Renderer{Front,Back}end simplification #9612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
headless-frontend
branch
from
096947d to
8ea2b78
Compare
ivovandongen
approved these changes
Jul 26, 2017
platform/node/src/node_map.hpp
Outdated
| class Map; | ||
| class HeadlessFrontend; | ||
| } // namespace mbgl | ||
|
|
||
| namespace node_mbgl { | ||
|
|
||
| class NodeRendererFrontend; |
There was a problem hiding this comment.
Could be removed too?
jfirebaugh
force-pushed
the
headless-frontend
branch
from
8ea2b78 to
eb9f421
Compare
jfirebaugh
force-pushed
the
headless-frontend
branch
from
eb9f421 to
aba9caf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another follow up on #9327 and #9541, this time focusing on
RendererFrontendandRendererBackend:HeadlessFrontendand make it the main coordinator for headless rendering. It replacesNodeRendererFrontend,AsyncRendererFrontend, andStubRendererFrontend. It contains aHeadlessBackendandRenderer, andOffscreenViewis merged intoHeadlessBackend. As a result, headless rendering clients only need to manage a single frontend object, instead of coordinating a frontend, a backend, a backend scope, a renderer, and a view.ViewintoRendererBackend. This is a natural followup, since as a result of the previous change, allRendererBackendimplementations also implementedView, and the one other implementation ofViewdid not actually need to do so (OffscreenTexture, which doesn't need to be used polymorphically).