Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Enable property functions for line-width #9214

Closed
wants to merge 3 commits into from
Closed

Enable property functions for line-width #9214

wants to merge 3 commits into from

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Jun 7, 2017

Counterpart of mapbox/mapbox-gl-js#4773.

To accomplish the same special casing here this PR

  • adds a line-floorwidth property at runtime in generate-style-code.js when it encounters line-width, with a skip: true property used by other ejs files to selectively generate property classes
  • the generated LineLayer::setLineWidth method sets LineFloorwidth as the same time as it sets LineWidth, and immediately marks that property to useIntegerZoom():
  • DataDrivenPropertyValue::useIntegerZoom() sets a bool useIntegerZoom on function values, which are used to determine whether to floor a zoom value in evaluating camera and composite functions

One thing I wasn't sure about was the evaluate() in src/mbgl/renderer/possibly_evaluated_property_value.hpp (this TODO) — in manually testing this with multiple combinations of constant/camera/source/composite functions, I never hit this breakpoint — how is this used, and is it also somewhere we should conditionally evaluate using integer zooms?

@lbud
Copy link
Contributor Author

lbud commented Jun 7, 2017

Er — investigating a few render tests ⚒

@kkaefer kkaefer added the Core The cross-platform C++ core, aka mbgl label Jun 8, 2017
@lbud
Copy link
Contributor Author

lbud commented Jun 19, 2017

Superseded by #9250.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants