This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Enable property functions for line-width #9214
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of mapbox/mapbox-gl-js#4773.
To accomplish the same special casing here this PR
line-floorwidth
property at runtime ingenerate-style-code.js
when it encountersline-width
, with askip: true
property used by other ejs files to selectively generate property classesLineLayer::setLineWidth
method setsLineFloorwidth
as the same time as it setsLineWidth
, and immediately marks that property touseIntegerZoom()
:DataDrivenPropertyValue::useIntegerZoom()
sets abool useIntegerZoom
on function values, which are used to determine whether to floor a zoom value in evaluating camera and composite functionsOne thing I wasn't sure about was the
evaluate()
insrc/mbgl/renderer/possibly_evaluated_property_value.hpp
(this TODO) — in manually testing this with multiple combinations of constant/camera/source/composite functions, I never hit this breakpoint — how is this used, and is it also somewhere we should conditionally evaluate using integer zooms?