This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - expose source layer identifier #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
8663-source-layer-identifier
branch
5 times, most recently
from
0b1bc30 to
da28a2f
Compare
|
Whitespacing has been adressed + fixed a couple of nit's in the existing code.
|
ivovandongen
approved these changes
Apr 13, 2017
| @@ -99,7 +108,7 @@ public class <%- camelize(type) %>Layer extends Layer { | |||
| return this; | |||
| } | |||
|
|
|||
| <% } -%> | |||
| <% } -%> | |||
There was a problem hiding this comment.
nit: probably accidental?
| @@ -144,6 +144,25 @@ namespace android { | |||
| } | |||
| } | |||
|
|
|||
| jni::String Layer::getSourceLayer(jni::JNIEnv& env) { | |||
There was a problem hiding this comment.
I set a bad example here (my apologies), but a more extensible way of doing this would be something like:
struct Evaluator {
std::string operator()(mbgl::style::BackgroundLayer&) { return {}; }
std::string operator()(mbgl::style::RasterLayer&) { return {}; }
std::string operator()(mbgl::style::CustomLayer&) { return {}; }
template <class VectorLayer>
std::string operator()(VectorLayer& layer) {
return layer.getSourceLayer();
}
};
...
std::string sourceLayerId = layer.accept(Evaluator());
maybe it's better though to clean this up separately in a pr and do the others in this class at the same time (might be quite some overlap).
There was a problem hiding this comment.
Follow up ticket in #8758
tobrun
force-pushed
the
8663-source-layer-identifier
branch
from
da28a2f to
e8b17b1
Compare
Once CI approves, going to merge |
This was referenced May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8663, need to fixup some whitespacing in the
.ejstemplate file before reviewing.This PR add a getter for source layer identifier on the layer classes that support it. Exposing this allows to iterate all layers and check for a specfic source layer identifiers, eg.
road.