Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] - add unit test for Mapbox #8228

Merged
merged 1 commit into from
Mar 1, 2017
Merged

[android] - add unit test for Mapbox #8228

merged 1 commit into from
Mar 1, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Feb 28, 2017

This PR adds a java unit test for Mapbox and tests the following:

  • accessToken validation
  • enforcing applicationContext
  • switching between Android Connectivity change events and manually managing them

Code coverage after adding the test:
screen shot 2017-02-28 at 17 24 49

@tobrun tobrun added Android Mapbox Maps SDK for Android tests labels Feb 28, 2017
@tobrun tobrun added this to the android-v5.0.0 milestone Feb 28, 2017
@tobrun tobrun self-assigned this Feb 28, 2017
@tobrun tobrun requested a review from zugaldia February 28, 2017 22:26
@mention-bot
Copy link

@tobrun, thanks for your PR! By analyzing this pull request, we identified @zugaldia to be potential reviewers.

@tobrun tobrun force-pushed the tvn-unit-test-mapbox branch from 7ef8077 to 57c531e Compare March 1, 2017 14:14
Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

field.set(mapbox, mapbox); got me confused, thanks for clarifying, maybe adding a comment before that line explaining that's required because it's a singleton?

@tobrun tobrun merged commit 95fdf3c into master Mar 1, 2017
@tobrun tobrun deleted the tvn-unit-test-mapbox branch March 1, 2017 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants