Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Note that canvas sources are unsupported #7808

Merged
merged 2 commits into from
Jan 23, 2017

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jan 21, 2017

mapbox/mapbox-gl-style-spec#656 added a canvas source type that only makes sense in a webpage context (but see #7471). This PR points out that canvas sources are unsupported in the iOS and macOS SDKs’ “Information for Style Authors” guide. Whereas most of the runtime styling API is generated automatically, the source API is maintained by hand, since each source type requires a unique set of initializers and methods.

Also fixed a typo in the same guide.

/cc @lbud @lucaswoj

@1ec5 1ec5 added documentation iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Jan 21, 2017
@1ec5 1ec5 added this to the ios-v3.4.1 milestone Jan 21, 2017
@1ec5 1ec5 self-assigned this Jan 21, 2017
@1ec5 1ec5 requested a review from ericrwolfe January 21, 2017 23:29
@lucaswoj
Copy link
Contributor

1e97815 looks good 👍

Not so sure what to make of b2c2765

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 23, 2017

Not so sure what to make of b2c2765

Just something I noticed along the way. Pay no mind. 😉

Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@1ec5 1ec5 merged commit b32c171 into release-ios-v3.4.0 Jan 23, 2017
@1ec5 1ec5 deleted the 1ec5-guide-style-canvas branch January 23, 2017 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants