This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix crash getting annotation view #6957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimized lookup of annotation tags by annotation from O(n) to a simple map lookup, for better performance and consistency with the iOS implementation of MGLMapView.
Streamlined -[MGLMapView annotationTagForAnnotation:] to use the mapping added in #5987. Reverted an unsafe access into that mapping that was added in #5987; returning nil is preferable when no such annotation can be found. Return the user location annotation view when given the user location annotation.
1ec5
added
iOS
boundsj
approved these changes
Nov 8, 2016
This was referenced Nov 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlined
-[MGLMapView annotationTagForAnnotation:]to use thestd::mapadded in #5987 on iOS. Added the samemapto the macOS implementation.Replaced unsafe calls to
std::map::at()– which throws an exception when the given element isn’t found – with calls to the newly streamlined-annotationTagForAnnotation:. One of these unsafe calls was added in #5987 and is reverted by this PR in favor of returningnil.Return the user location annotation view when given the user location annotation.
Fixes #6953.
/cc @boundsj