This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Make feature attributes and identifier writable #6728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instances of MGLFeature subclasses can now have their attributes and identifier properties mutated.
|
@boundsj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1ec5, @incanus and @friedbunny to be potential reviewers. |
1ec5
suggested changes
Oct 18, 2016
| @@ -50,7 +50,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
| <a href="https://www.mapbox.com/vector-tiles/mapbox-streets/">Mapbox Streets</a> | |||
| layer reference. | |||
There was a problem hiding this comment.
Point out that you can change this property and attributes on an MGLFeature obtained using feature querying, but doing so has no effect on the map.
1ec5
approved these changes
Oct 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instances of MGLFeature subclasses can now have their attributes and identifier properties mutated.
Follow up to #6302
cc @1ec5