This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Emit MapChangeDidFailLoadingMap when the style cannot be loaded or parsed #6142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d or parsed Currently this signal is never emitted, which can cause the Still mode to starve in case of an invalid style or failed request.
|
@tmpsantos, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @1ec5 and @mikemorris to be potential reviewers. |
|
Awesome, I think this will partially fix #2762. /cc @friedbunny |
|
👍 |
|
Took care of some tail work on iOS and macOS in #6145. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this signal is never emitted, which can cause the Still mode to starve in case of an invalid style or failed request.