This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Stop exaggerating heading accuracy indicator size #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
iOS
|
Unsure if this rises to changelog status. Probably? Haven’t added anything yet. |
Sure, why not. There’s visual impact to the user. |
|
👍 |
friedbunny
force-pushed
the
fb-heading-indicator-accuracy
branch
from
62d8c67 to
a3ea503
Compare
|
Added a changelog entry. I also realized that I hadn’t changed the maximum accuracy clipping size, so I went back and updated that to 20° (
(Google doesn’t represent heading accuracy and uses a static heading arrow.) |
|
Note: I’m seeing reported accuracy as high as 10°, but we should still clip to 20° for display purposes. |
friedbunny
force-pushed
the
fb-heading-indicator-accuracy
branch
from
a3ea503 to
c1a3a77
Compare
- 1.5× exaggeration has been removed. - Maximum accuracy (smallest size) has been increased to 20°.
- Use MGLRadiansFromDegrees(). - Make indentation more readable.
friedbunny
force-pushed
the
fb-heading-indicator-accuracy
branch
from
c1a3a77 to
9cdbac0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the 1.5× exaggeration of the user location annotation’s heading indicator.
Also cleaned up some of the heading mask calculations while I was at it.
Fixes #3718.
/cc @1ec5